Update to latest skia library #20
Conversation
|
|
||
| # install tox to run test suite in a virtual environment | ||
| - pip install --upgrade tox | ||
|
|
||
| # build wheel | ||
| - tox -e wheel | ||
| - pip wheel --no-deps --wheel-dir dist . |
There was a problem hiding this comment.
I changed appveyor to build directly using pip instead of indirectly calling tox, because some environment variable was not getting through the tox sandboxing. I know I can use passenv but I didn't know exactly the name of the required env vars (doing passenv=* would have been even lazier). It's not really necessary to build the wheel inside a tox virtual environment. This works just fine.
The tests using the pre-built wheel are still being run inside tox.
| - os: linux | ||
| env: | ||
| - MB_PYTHON_VERSION=2.7 | ||
| - UNICODE_WIDTH=16 |
There was a problem hiding this comment.
"narrow" unicode linux py27 builds are also gone, nobody uses these nowadays
|
The overwritten test case is suspicious, need to visualize. |
|
Old: New: |
|
Thanks for visualizing it! |
|
|
|
Ok. Well, very weird test contours we have. I'm inclined to merge this anyway. |
|
Does this skia update fix any of the issues where additional inflection points are added or other issues reported on fonttools path ops? |
|
unfortunately no.. |
|
btw it looks like Cary Clark has left Google since the time we got in touch about these issues. |
This updates the embedded skia library to the latest revision from git mirror's master branch.
Since currently skia requires a C++14 compiler (and it's 2019), I had to remove support for the 32-bit builds and also for the Windows 2.7 build. I'm still building python 2.7 for Linux/Mac, we can keep that until cython drops supports.
To build for the manylinux1 platform, I needed to use a more recent gcc compiler than the one in the default Docker image from PyPA. I used one that has gcc-9.1.0, and also passed
-static-libstdc++flag.For Windows, I need to use Visual Studio 2017, which is the miniumum one that supports C++14.
For macOS, specifically only for the Python 3.6 build (not sure why that, and not also for 2.7 or 3.7...), I needed to patch one of skia headers to rename a symbol that was clashing with another macro defined in
sys/termios.hsystem header.This is the patch:
https://github.com/google/skia/compare/master...fonttools:fix-B0-macro?expand=1
The src/cpp/skia git submodule is configured to point to our skia fork at
fonttools/skia.I will file a bug report upstream sometime later.
There's also one test case that changed output. I haven't had the chance to look at it visually to confirm that it's doing the right thing. I was lazy and simply updated the expected test results.