Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wght named instances check #3335

Closed
3 tasks
davelab6 opened this issue Jun 9, 2021 · 5 comments
Closed
3 tasks

Update wght named instances check #3335

davelab6 opened this issue Jun 9, 2021 · 5 comments
Assignees
Labels
GF's priority list List of high priority issues for google/fonts CI P1 Quick Severity 4
Milestone

Comments

@davelab6
Copy link
Contributor

davelab6 commented Jun 9, 2021

As explained in google/fonts#3453 (comment)

  • For static families, any x100 weights within the min-max range that are missing should FAIL. Eg, if range is 400 to 900, and static styles are 400 500 700 900, then 600 and 800 are missing and should FAIL.
  • For VF families, any x100 weight named instances missing from the fvar table should FAIL.
  • For VF families, any x100 weight named instances missing from the STAT table should FAIL.
@RosaWagner
Copy link
Contributor

The rationale could advise designer to reduce the range of their axis if it seems that there is not enough space between two instances to add an intermediate one. Except for already published instances — it would create a regression.

Classical cases is ExtraLight: Thin and Light being too close visually for adding an ExtraLight. In that case, we could suggest to reduce the range, Thin would become ExtraLight.

Other classical but tricky case: the need of SemiBold when the range cover until Bold. Here, Medium and Bold are too close visually to add a SemiBold, but the range can't be reduced cause the Bold instance is more important to have because of style linking etc. Then, we have no choice than to change the location of the Medium to make space for a SemiBold, OR to leave it like that and the SemiBold will be kind of useless and absurd (but at least the designer has his Medium where he wants it).

@davelab6
Copy link
Contributor Author

Yes - thank you - a part of the rationale for that I've explained here, xotypeco/big_shoulders#36 (comment) - but those common cases are excellent to explain

@RosaWagner
Copy link
Contributor

We need that in the release 0.8.9

@felipesanches
Copy link
Collaborator

I'm sorry, but I will try to make it happen by 0.8.10

@felipesanches felipesanches modified the milestones: 0.8.9, 0.8.10 Jun 10, 2022
@felipesanches felipesanches modified the milestones: 0.8.10, 0.8.17 Jun 24, 2022
@felipesanches felipesanches added the GF's priority list List of high priority issues for google/fonts CI label Nov 29, 2022
@RosaWagner
Copy link
Contributor

This proposal has been fixed with the implementation of the axis registry check

@felipesanches felipesanches modified the milestones: 0.9.3, 0.9.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GF's priority list List of high priority issues for google/fonts CI P1 Quick Severity 4
Projects
None yet
Development

No branches or pull requests

4 participants