Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[progress] min-width of bar is a bit too short #3068

Open
Grosskopf opened this issue Jul 5, 2024 · 2 comments
Open

[progress] min-width of bar is a bit too short #3068

Grosskopf opened this issue Jul 5, 2024 · 2 comments
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@Grosskopf
Copy link

Bug Report

Due to flaw in the css definition of the progress text, 11% can be interpreted as 1% at first glance in cases where the progress bar is slim

Steps to reproduce

  1. have a ui progress with a width of ~250px
  2. set the progress to 10.5%
  3. notice how the first "1" of the rounded "11" is not visible

Expected result

I expected to be able to see the 11 easily

Actual result

I only see the 1% part of the text 11% fully as the text is moved out to the left

Testcase

https://jsfiddle.net/gq045pk7/3/ includes two possible solutions

Screenshot (if possible)

screenshot showing a progress bar with the text 11% but the first 1 is not visible completely

Version

2.9.3

@Grosskopf Grosskopf added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jul 5, 2024
@Grosskopf
Copy link
Author

Noticed this, because in our case we were using the font "Open Sans sans-serif" which makes it even less noticeable

https://jsfiddle.net/ep3rwhq1/
the same screenshot now with a sans-serif font showing that even the little notch that could draw attention to the missing 1 character is missing

@lubber-de
Copy link
Member

lubber-de commented Jul 6, 2024

Fixed by #3069
I decided to use your suggested min-width fix (2nd example) as it is compatible to all variants.

@lubber-de lubber-de added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Jul 6, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Jul 6, 2024
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants