fix(lspconfig): add hook before and not after #92
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A common use of
on_new_config
is to construct thecmd
for starting language servers based on the configuration. These language servers require that the settings are finalized before it is run. It looks like previous commits did useadd_hook_before
for thelspconfig
integration but it got moved to beingadd_hook_after
when centralizing it with thelua_ls
andjsonls
plugin integrations. We should revert this back toadd_hook_before
so that the existingon_new_config
functions continue working.