UIU-2951: change disabled button style (#2568)

* UIU-2951: change disabled button style * tests: fix failing test cases * UIU-2951: remove css styling and move the logic to stripes-components * refactor: hide disabled elements * refactor: hide button for shadow users
folio-org · Oct 11, 2023 · 98a3c5c · 98a3c5c
1 parent f5c9e37
commit 98a3c5c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 23 deletions.
diff --git a/src/components/RequestFeeFineBlockButtons/RequestFeeFineBlockButtons.js b/src/components/RequestFeeFineBlockButtons/RequestFeeFineBlockButtons.js
@@ -17,7 +17,6 @@ class RequestFeeFineBlockButtons extends React.Component {
     onToggle: PropTypes.func,
     userId: PropTypes.string,
     location: PropTypes.object,
-    disabled: PropTypes.bool,
   };
 
   render() {
@@ -26,7 +25,6 @@ class RequestFeeFineBlockButtons extends React.Component {
       onToggle,
       userId,
       location,
-      disabled,
     } = this.props;
     const createRequestUrl = getRequestUrl(barcode, userId);
 
@@ -38,7 +36,6 @@ class RequestFeeFineBlockButtons extends React.Component {
             data-test-actions-menu-create-request
             to={createRequestUrl}
             onClick={onToggle}
-            disabled={disabled}
           >
             <Icon icon="plus-sign">
               <FormattedMessage id="ui-users.requests.createRequest" />
@@ -51,7 +48,6 @@ class RequestFeeFineBlockButtons extends React.Component {
             data-test-actions-menu-create-feesfines
             to={{ pathname: `/users/${userId}/charge` }}
             onClick={onToggle}
-            disabled={disabled}
           >
             <Icon icon="plus-sign">
               <FormattedMessage id="ui-users.accounts.chargeManual" />
@@ -63,7 +59,6 @@ class RequestFeeFineBlockButtons extends React.Component {
             buttonStyle="dropdownItem"
             data-test-actions-menu-create-patronblocks
             id="create-patron-block"
-            disabled={disabled}
             to={{
               pathname: `/users/${userId}/patronblocks/create`,
               search: location.search,

diff --git a/src/components/RequestFeeFineBlockButtons/RequestFeeFineBlockButtons.test.js b/src/components/RequestFeeFineBlockButtons/RequestFeeFineBlockButtons.test.js
@@ -44,15 +44,6 @@ describe('RequestFeeFineBlockButtons', () => {
       expect(screen.queryByText('ui-users.accounts.chargeManual')).toBeInTheDocument();
       expect(screen.queryByText('ui-users.blocks.buttons.add')).toBeInTheDocument();
     });
-
-    it('should createRequest button to be disabled', () => {
-      renderRequestFeeFineBlockButtons({ disabled: true });
-      const buttonElements = screen.getAllByRole('button');
-
-      buttonElements.forEach((buttonElement) => {
-        expect(buttonElement).toBeDisabled();
-      });
-    });
   });
 
   describe('without ui-requests.all permission', () => {

diff --git a/src/views/UserDetail/UserDetail.js b/src/views/UserDetail/UserDetail.js
@@ -446,22 +446,24 @@ class UserDetail extends React.Component {
     if (showActionMenu) {
       return (
         <>
-          <IfInterface name="feesfines">
-            <RequestFeeFineBlockButtons
-              barcode={barcode}
-              onToggle={onToggle}
-              userId={this.props.match.params.id}
-              disabled={isShadowUser}
-            />
-          </IfInterface>
+          {!isShadowUser && (
+            <IfInterface name="feesfines">
+              <RequestFeeFineBlockButtons
+                barcode={barcode}
+                onToggle={onToggle}
+                userId={this.props.match.params.id}
+                disabled={isShadowUser}
+              />
+            </IfInterface>
+          )}
           <ActionMenuEditButton
             id={this.props.match.params.id}
             suppressList={this.props.resources.suppressEdit}
             onToggle={onToggle}
             goToEdit={this.goToEdit}
             editButton={this.editButton}
           />
-          <LostItemsLink />
+          {!isShadowUser && <LostItemsLink />}
           <IfInterface name="feesfines">
             <ExportFeesFinesReportButton
               feesFinesReportData={feesFinesReportData}