Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2617: Add immediate warning message when a local instance is shared #2321

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

mariia-aloshyna
Copy link
Contributor

@mariia-aloshyna mariia-aloshyna commented Oct 25, 2023

Purpose

After discussion with UI devs, plan to show an orange warning message immediately after the Share button is pushed, and then a green success message after the sharing is complete. The green toast is already in place. This PR implments the orange warning message.

Approach

  • Refactor InstanceDetails component
  • Render warning banner when instance sharing started

Refs

https://issues.folio.org/browse/UIIN-2617

Screenshots

Screen.Recording.2023-10-26.at.12.52.38.mov

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   14m 9s ⏱️ + 3m 44s
888 tests +1  886 ✔️ +1  2 💤 ±0  0 ±0 
893 runs  +1  891 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit e5eb10f. ± Comparison against base commit 33589f7.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

97.6% 97.6% Coverage
0.0% 0.0% Duplication

@mariia-aloshyna mariia-aloshyna merged commit 09b0d1b into master Oct 26, 2023
4 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-2617 branch October 26, 2023 13:39
mariia-aloshyna added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants