Skip to content

Commit

Permalink
OKAPI-1172: Reduce excessive logging on deploy
Browse files Browse the repository at this point in the history
When Okapi deploys a module it logs the complete module descriptor.

This is too verbose. It is not needed because the information is available with `docker inspect`.
  • Loading branch information
julianladisch committed Sep 13, 2023
1 parent 7d26d90 commit 76dd5e8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private Future<DeploymentDescriptor> deploy2(int usePort, DeploymentDescriptor m
}
descriptor.setEnv(nenv);
}
logger.info("Deploy {} {}", md.getSrvcId(), Json.encodePrettily(descriptor));
logger.info("Deploy {} {}", md.getSrvcId(), md.getDescriptor().getDockerImage());
String moduleUrl = "http://" + host + ":" + usePort;
String moduleHost = host;
if (descriptor.getDockerImage() != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ Future<DeploymentDescriptor> addAndDeployIgnoreError(DeploymentDescriptor dd) {
* </ol>
*/
private Future<DeploymentDescriptor> addAndDeploy0(DeploymentDescriptor dd) {
String tmp = Json.encodePrettily(dd);
logger.info("addAndDeploy: {}", tmp);
final String id = dd.getSrvcId();
logger.info("addAndDeploy: {} {} {}", dd.getNodeId(), id,
dd.getDescriptor() == null ? null : dd.getDescriptor().getDockerImage());
if (id == null) {
return Future.failedFuture(new OkapiError(ErrorType.USER, messages.getMessage("10800")));
}
Expand Down

0 comments on commit 76dd5e8

Please sign in to comment.