I recommend a good example to add to tests\statement_serializator_tests\ast\upsert_clause.cpp

[juandent]

Hi Eugene,

I think upsert tests would benefit from a more complete example and test_case. I propose the following:

// JDH next test_case
TEST_CASE("upsert_clause_complete") {

////////////////////////
/*
    CREATE TABLE phonebook2(
        name TEXT PRIMARY KEY,
        phonenumber TEXT,
        validDate DATE
    );
    INSERT INTO phonebook2(name, phonenumber, validDate)
        VALUES('Alice', '704-555-1212', '2018-05-08')
        ON CONFLICT(name) DO UPDATE SET
        phonenumber = excluded.phonenumber,
        validDate = excluded.validDate
        WHERE excluded.validDate > phonebook2.validDate;
*/

    struct phonebook{
        std::string name;
        std::string phonenumber;
        std::string validDate;
    };

    auto phonebookTable = make_table("phonebook",
        make_column("name", &phonebook::name, primary_key()),
        make_column("phonenumber", &phonebook::phonenumber, default_value("")),
        make_column("validDate", &phonebook::validDate));

    auto storage = make_storage("upsert_complete.sqlite", phonebookTable);
    storage.sync_schema();

    auto rowsBefore = storage.get_all<phonebook>();

    storage.insert(into<phonebook>(), columns(&phonebook::name, &phonebook::phonenumber, &phonebook::validDate), values(std::make_tuple("Alice", "506-555-1212", datetime("now"))), 
        on_conflict(&phonebook::name).do_update(set(assign(&phonebook::phonenumber, excluded(&phonebook::phonenumber)),assign(&phonebook::validDate, excluded(&phonebook::validDate))), where(excluded(&phonebook::validDate) > c(&phonebook::validDate))));

    auto rows = storage.get_all<phonebook>();
    if (!rowsBefore.empty())
    {
        REQUIRE(rows[0].validDate != rowsBefore[0].validDate);
    }
 }

Do you like it?
BTW, which type in C++ serializes to DATE in sqlite? I understood DATE was not a type in sqlite!

Regards,
Juan

[fnc12]

Yes I like it. BTW example exists https://github.com/fnc12/sqlite_orm/blob/dev/examples/insert.cpp#L121