Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote neighbour contribution communicates unnecessary zeroed out buffers #693

Open
markusbattarbee opened this issue Jan 30, 2023 · 0 comments

Comments

@markusbattarbee
Copy link
Contributor

In


we communicate zeroed out buffers in order to handle remote neighbour communication when a lower-refinement level cells is a remote face neighbour. It would be more efficient to instead mark that buffer as unnecessary, not communicate it, and then also on the receiving end not sum it into the already valid data.

This would mean that instead of setting the communicated block count at

ccell->neighbor_number_of_blocks.at(sendIndex) = pcell->get_number_of_velocity_blocks(popID);

It'd need to be set inside the following if-region.

I guess then the communication at line 2017 should be split into two; first communicate neighbor block counts, then neighbor block data. Otherwise there should be some failsafe that only the first sibling for each communicate pair gets the blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant