Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] An option to show only HQ items #50

Open
GnawtyVeritech opened this issue Aug 28, 2022 · 11 comments
Open

[Feature Request] An option to show only HQ items #50

GnawtyVeritech opened this issue Aug 28, 2022 · 11 comments

Comments

@GnawtyVeritech
Copy link

Thank you for writing this mod. It has been very useful in shopping for the best deals. Could an option be added to show only HQ items in the future?

@GnawtyVeritech GnawtyVeritech changed the title An option to show only HQ items [Feature Request] An option to show only HQ items Aug 28, 2022
@Pythyu
Copy link
Contributor

Pythyu commented Aug 28, 2022

Very nice idea :)
Yes it's completely feasible, i'll work on it.
Do you think it's better into the advanced search menu or as a settings in the setting menu ?
Advanced search menu seems better for it in my opinion

@GnawtyVeritech
Copy link
Author

I think this one might be frequently used enough (especially during patch days or crafter rushes) to have it as an option below or near "Data provided by Universalis".

@Pythyu
Copy link
Contributor

Pythyu commented Aug 29, 2022

Uhmm yea but I kind don't want to put option everywhere otherwise it might be confusing but yeah what I'll try is make the advanced search menu slimer and a bit better looking. Then add an HQ Only option there. It shouldn't be a problem for long usage since your search settings are saved as long as your game is open. I'd like to show you a picture of what it looks like with my changes but sadly, I can't test currently because of the new update.

@Pythyu
Copy link
Contributor

Pythyu commented Aug 29, 2022

For now it looks like something like that
advsearch2

@GnawtyVeritech
Copy link
Author

I think that spot is good. My biggest use case is when I am trying to find the price of an HQ equipment piece, and I use the cursor to highlight it to auto-search (I don't think I've ever entered an item to search for manually). Lately there have been some sellers listing NQ equipment for super low prices, causing me to have to scroll through pages to find what I actually need. Will the filter function even using the cursor highlight method?

@Pythyu
Copy link
Contributor

Pythyu commented Aug 30, 2022

Yes I'll make sure it works by hovering.
Last question, should the HQ Only filter be applied on the recent history as well to see HQ previous purchases only or to current market data alone ?

@Pythyu
Copy link
Contributor

Pythyu commented Aug 30, 2022

2 sample >
HQ Only applied on both market data and history
HQOnly1
HQ Only applied only on market data and not on history
HQOnly2

@GnawtyVeritech
Copy link
Author

Hmm... that is a tough call. As the base FF14 sorts Recent History by date/time regardless of HQ, maybe we can follow their example for now and do the same. So the filter only sorts the price list, not the history.

I think there may be opinions from users going either way, however.

@Pythyu
Copy link
Contributor

Pythyu commented Aug 30, 2022

Ok for now I'll follow your opinion. If later ppl ask for it I might add a second option or something I'll see

@Pythyu
Copy link
Contributor

Pythyu commented Aug 30, 2022

Implemented in PR #54

@Pythyu
Copy link
Contributor

Pythyu commented Feb 12, 2023

Solved (little cleanup of issues ^^) @fmauNeko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants