Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADO build pipeline #117

Closed
lvanvugt opened this issue Nov 27, 2022 · 6 comments · Fixed by #120
Closed

Fix ADO build pipeline #117

lvanvugt opened this issue Nov 27, 2022 · 6 comments · Fixed by #120
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lvanvugt
Copy link
Contributor

Issue
ADO build is failing

[might need to add some more details]

Notes

  • Maybe lower prio right now, but does it also publish to VS Code marketplace?
@lvanvugt lvanvugt added the bug Something isn't working label Nov 27, 2022
@lvanvugt lvanvugt added this to the v1 milestone Nov 27, 2022
@christianbraeunlich
Copy link
Contributor

christianbraeunlich commented Dec 1, 2022

Hello there,
wanted to ask if I could contribute on this one - I would use github actions instead of ADO if that's in your interest: have a look at the following vs code web-extension example https://github.com/christianbraeunlich/chewbacca
answer to the question from the issue-description: the azure-pipelines.yml (https://github.com/fluxxus-nl/ATDD.TestScriptor.VSCodeExtension/blob/master/azure-pipelines.yml) already includes a publish to marketplace step

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Dec 1, 2022

Thanx @christianbraeunlich for the offer. I leave it to @martonsagi to judge.

@martonsagi
Copy link
Collaborator

I'm not against it, the current pipeline is from the old ages. :)
If every step can properly be replaced, I'd welcome the contribution! My main concern atm is the Aurelia building part, which is causing the current failures.

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Dec 6, 2022

@martonsagi could you review (and possible approve) the PR for #120 ?

If approved we can close both #120 and this one.

@christianbraeunlich
Copy link
Contributor

Hi @lvanvugt, could you test the latest build artifact (https://fluxxus.visualstudio.com/TestScriptor/_build/results?buildId=257&view=artifacts&pathAsName=false&type=publishedArtifacts) to verify that everything is still working as expected? tia

@lvanvugt
Copy link
Contributor Author

Hi @lvanvugt, could you test the latest build artifact (https://fluxxus.visualstudio.com/TestScriptor/_build/results?buildId=257&view=artifacts&pathAsName=false&type=publishedArtifacts) to verify that everything is still working as expected? tia

LOL, partly doing it right now. Will do more testing in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants