Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using buildah for pushing containers #1351

Closed
dsalaza4 opened this issue Jul 12, 2024 · 3 comments
Closed

Consider using buildah for pushing containers #1351

dsalaza4 opened this issue Jul 12, 2024 · 3 comments

Comments

@dsalaza4
Copy link
Contributor

dsalaza4 commented Jul 12, 2024 •
edited
Loading

We currently use skopeo for pushing container images https://github.com/fluidattacks/makes/blob/main/src/args/deploy-container-image/default.nix#L17

let's consider using buildah, mainly because it looks like it supports multi-architecture images: containers/skopeo#1136 (comment)

Having a single makes container that supports both x86 and aarch64 would be awesome.
@dsalaza4
Copy link
Contributor Author

For reference: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

@dsalaza4
Copy link
Contributor Author

https://github.com/estesp/manifest-tool this one looks even better?

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
refac(back): fluidattacks#1351 simplify builtin name
538122b 
- Rename from deployContainerImage to deployContainer
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
refac(back): fluidattacks#1351 simplify builtin name
00b0a1a 
- Rename from deployContainerImage to deployContainer
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
refac(back): fluidattacks#1351 simplify builtin name
fb94869 
- Rename from deployContainerImage to deployContainer

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 26, 2024
@dsalaza4
Merge pull request #1358 from dsalaza4/dsalazaratfluid
11428d7 
refac(back): #1351 simplify builtin name
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
refac(back): fluidattacks#1351 rename directories
d323805 
- Rename directories according to new
builtin name

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
refac(back): fluidattacks#1351 rename directories
ce6be8d 
- Rename directories according to new
builtin name

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 26, 2024
@dsalaza4
Merge pull request #1359 from dsalaza4/dsalazaratfluid
4043825 
refac(back): #1351 rename directories
@dsalaza4
Copy link
Contributor Author

image

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
feat(back): fluidattacks#1351 deploy container manifest
5a93aaf 
- Add builtin
- Add documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
feat(back): fluidattacks#1351 deploy container manifest
95a50fb 
- Add builtin
- Add documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 26, 2024
@dsalaza4
feat(back): fluidattacks#1351 deploy container manifest
2342f91 
- Add builtin
- Add documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 26, 2024
@dsalaza4
Merge pull request #1360 from dsalaza4/dsalazaratfluid
33a9564 
feat(back): #1351 deploy container manifest
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 27, 2024
@dsalaza4
refac(back): fluidattacks#1351 adapt cosign
c215abf 
- Adapt cosign command
to avoid storing sensitive data
in disk
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 27, 2024
@dsalaza4
refac(back): fluidattacks#1351 adapt cosign
b127878 
- Adapt cosign command
to avoid storing sensitive data
in disk

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 27, 2024
@dsalaza4
Merge pull request #1361 from dsalaza4/dsalazaratfluid
aeccaa5 
refac(back): #1351 adapt cosign
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 27, 2024
@dsalaza4
feat(back): fluidattacks#1351 multi-arch container
5329fd3 
- Deploy multi-arch container on
`fluidattacks/makes:latest`
- Stop using arch-based registries in favor
of the root one
- Remove unnecessary CI jobs
- Update documentation on recommended makes container

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 27, 2024
@dsalaza4
feat(back): fluidattacks#1351 multi-arch container
aa1ada1 
- Deploy multi-arch container on
`fluidattacks/makes:latest`
- Stop using arch-based registries in favor
of the root one
- Remove unnecessary CI jobs
- Update documentation on recommended makes container
- Format bash code

Signed-off-by: Daniel Salazar <[email protected]>
jpverde added a commit that referenced this issue Jul 27, 2024
@jpverde
Merge pull request #1362 from dsalaza4/dsalazaratfluid
f0d8021 
feat(back): #1351 multi-arch container
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jul 27, 2024
@dsalaza4
fix(build): fluidattacks#1351 amd64 nixos image
9c7595a 
- Use amd64 nixos image for pushing multi-arch
manifest

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 27, 2024
@dsalaza4
Merge pull request #1363 from dsalaza4/dsalazaratfluid
9b48d0e 
fix(build): #1351 amd64 nixos image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsalaza4