Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate version mismatch #1076

Open
dacevedo12 opened this issue Apr 26, 2023 · 2 comments
Open

Validate version mismatch #1076

dacevedo12 opened this issue Apr 26, 2023 · 2 comments

Comments

@dacevedo12
Copy link
Collaborator

image

When the user has an old version of makes and attempts to run a command from a newer one

The proposal is to handle this case, showing a clear error on why it happened and how to update makes

@dsalaza4
Copy link
Contributor

I think the best way to do this would be by checking if both the CLI and the framework of Makes are pointing to a commit within the same version.

if not same_version(makes_cli, makes_framework):
   warn(
      f"You are currently using Makes CLI v{makes_cli.version}, "
      f"but have Makes framework v{makes_framework.version} pinned on your makes.lock.nix file. "
      f"This may cause incompatibility issues."
   )

@dsalaza4
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants