-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppDelegate.mm install instructions for RN 0.71 #51
Comments
Hi @jaredh159 Have you found a solution to the integration problem ? I tried to use your sample code, but after building on iOS, the app crashes without errors. |
the code i showed above is working for me. i'm guessing maybe your crash has to do with something else? make sure you've also added: #import <RNHomeIndicator.h> |
Updated location on github for those whore interested https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L127 |
I was experiencing build issues using the recommended install steps on RN 0.71.X. Thanks a lot! |
RN 0.71 seems to have changed the AppDelegate entrypoint significantly. From piecing together info from
facebook/react-native#35937
and
https://github.com/facebook/react-native/blob/main/Libraries/AppDelegate/RCTAppDelegate.h
I think the correct way to install, replacing the default UIViewController would be to add a new method override like so:
does that seem correct to you? if so, would you be open to a PR to modify the readme?
The text was updated successfully, but these errors were encountered: