Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in shared URLS/uploaded files not converted to %20 #60

Open
devkev opened this issue Jan 16, 2015 · 1 comment
Open

Spaces in shared URLS/uploaded files not converted to %20 #60

devkev opened this issue Jan 16, 2015 · 1 comment

Comments

@devkev
Copy link

devkev commented Jan 16, 2015

When files are uploaded to a flow, the URL sent via IRC isn't properly URL-encoded. Specifically, spaces aren't converted to %20. This gives things like this:

<RandomPerson> https://www.flowdock.com/rest/files/81438/n3ISn0DBwkVhTkTYGm_nQQ/Screenshot 2015-01-15 13.26.33.png

which are unclickable in most IRC clients. It should instead be

<RandomPerson> https://www.flowdock.com/rest/files/81438/n3ISn0DBwkVhTkTYGm_nQQ/Screenshot%202015-01-15%2013.26.33.png
@devkev
Copy link
Author

devkev commented Jan 16, 2015

Looks like the culprit is here:

url = "https://www.#{IrcServer::FLOWDOCK_DOMAIN}/rest#{@message['content']['path']}"

Just need to properly URI escape the contents of @message['content']['path'], right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant