Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a module that exports the client proxy #2

Open
harrietwaters opened this issue Apr 14, 2021 · 0 comments · May be fixed by #30
Open

Add a module that exports the client proxy #2

harrietwaters opened this issue Apr 14, 2021 · 0 comments · May be fixed by #30
Assignees
@harrietwaters
Labels
enhancement New feature or request

Comments

@harrietwaters
Copy link
Collaborator

In order to make the client proxy easier to use, it should be injectable - which means we need to export a module/service.

Service should only export the client proxy, and must provide a static factory method to allow the client proxy to be configured.
@harrietwaters harrietwaters added the enhancement New feature or request label Apr 14, 2021
@harrietwaters harrietwaters self-assigned this Apr 17, 2021
harrietwaters added a commit that referenced this issue Apr 17, 2021
@harrietwaters
feat(client): add and export a module that allows the client proxy to…
07a5820 
… be injected

Provide a GooglePubSubModule that exports a client proxy instance, allowing it to be injected

re #2
@harrietwaters harrietwaters linked a pull request Apr 17, 2021 that will close this issue
Open
@harrietwaters harrietwaters linked a pull request Apr 17, 2021 that will close this issue
feat(client): add and export a module that exports the client proxy #30
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrietwaters harrietwaters

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@harrietwaters