New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Returns correct state when referenceElement becomes null #374

Open

lmk123 wants to merge 2 commits into floating-ui:master from lmk123:patch-1

lmk123 commented Jul 6, 2020

When I change referenceElement or popperElement to null, usePopper returns old state to me.

Steps To Reproduce

open the reproduce link: https://codepen.io/lmk123/pen/zYrRzMM
click the 'Set referenceElement to null' button

Expected behavior: state.placement becomes null
Current behavior: state.placement is still bottom

lmk123 added 2 commits

July 6, 2020 15:51


          fix: returns correct state when referenceElement becomes null

a92108a


          fix: reset styles and attributes as well

a14439d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet