From 140b78b7cf83a2e9be8dfe3c64b92afb8063982f Mon Sep 17 00:00:00 2001 From: George MacRorie Date: Fri, 17 Nov 2023 14:28:52 +0000 Subject: [PATCH 1/3] chore(guides): add link to forkable example repo --- guides/get-going-with-gitops.mdx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/guides/get-going-with-gitops.mdx b/guides/get-going-with-gitops.mdx index 45f4629..40fff20 100644 --- a/guides/get-going-with-gitops.mdx +++ b/guides/get-going-with-gitops.mdx @@ -39,6 +39,11 @@ While we feel confident in our implementation, we're going to practice caution a ### The Application + + If you want to follow along you can fork [this + repository](https://github.com/flipt-io/flipt-gitops-guide). + + ```bash . ├── go.mod From b52847cf2858f9f602127b311e3e37e9589056eb Mon Sep 17 00:00:00 2001 From: George MacRorie Date: Fri, 17 Nov 2023 14:50:27 +0000 Subject: [PATCH 2/3] chore(guides): add some curl examples to gitops guide --- guides/get-going-with-gitops.mdx | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/guides/get-going-with-gitops.mdx b/guides/get-going-with-gitops.mdx index 40fff20..eb85ced 100644 --- a/guides/get-going-with-gitops.mdx +++ b/guides/get-going-with-gitops.mdx @@ -240,6 +240,13 @@ git push origin main Once Flipt has received the updated reference, our flag should be available through Flipt's API. The code change we added can now safely reference the present flag, which is currently in a `disabled` state. +This is where you might use something like `curl` to ensure the service is still behaving as expected: + +```bash +# the -w option prints timing output at the end +curl -w "\nTotal: %{time_total}s\n" "http://localhost:8000/words" +``` + Next we will begin to enable the flag under different conditions. ## Targeting and Rollouts @@ -342,6 +349,10 @@ Whereas, the rest of users should still be served using the old Bubble Sort algo entries. You can fix those changes now before targeting more users. +```bash +curl -w "\nTotal: %{time_total}s\n" "http://localhost:8000/words?org=internal-users" +``` + ### Proportional Rollout Once we're confident our change is working as expected, since we've validated the change in production for `internal` users, we can start to roll it out to external users. @@ -481,7 +492,7 @@ At each commit, we could've fully recreated the configuration of our entire appl Now you have all the tools necessary to practice GitOps with your feature flags. However, in production, your mileage may vary with the different backed types. -You might want to consider the `object` (and AWS S3 type) backend if your source Git repositories are large (we're working on a guide for that now). +You might want to consider the `object` (and AWS S3 type) or the `oci` backend if your source Git repositories are large (we're working on a guide for that now). The declarative storage backends currently mandate that the UI is **read-only**. We've thoughts on how this could change in the future, but for now, this is a limitation. From 73401e311e32038b1d3d774a0877e10cb700b22c Mon Sep 17 00:00:00 2001 From: George Date: Fri, 17 Nov 2023 14:55:35 +0000 Subject: [PATCH 3/3] chore: apply suggestions from code review Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com> --- guides/get-going-with-gitops.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guides/get-going-with-gitops.mdx b/guides/get-going-with-gitops.mdx index eb85ced..3183cd7 100644 --- a/guides/get-going-with-gitops.mdx +++ b/guides/get-going-with-gitops.mdx @@ -40,7 +40,7 @@ While we feel confident in our implementation, we're going to practice caution a ### The Application - If you want to follow along you can fork [this + If you want to follow along you can fork our [gitops guide repository](https://github.com/flipt-io/flipt-gitops-guide). @@ -240,7 +240,7 @@ git push origin main Once Flipt has received the updated reference, our flag should be available through Flipt's API. The code change we added can now safely reference the present flag, which is currently in a `disabled` state. -This is where you might use something like `curl` to ensure the service is still behaving as expected: +This is where you would use `curl` to ensure the service is still behaving as expected: ```bash # the -w option prints timing output at the end