Type checking

[mrRachar]

Currently type checking doesn't seem to be properly implemented or checked. The following programme is able to pass through the semantic analysis stage of the compiler.

contract Test { }

Test :: (any) {
    public init() {
        var x: [Address] = 1
        var y: Bool = x
    }
}

The above example compiles without errors, although the generated code displays the same flaws (so the subsequent compiler will complain, although in such a way which is not useful for Flint users).

Note type checking does also not occur for return types:

contract Test { }

Test :: (any) {
    public init() {
        test()
    }

    func test() -> Bool {
        return 5
    }
}

Progress

• Type checking for assignments
• Type checking within expressions (_: Int + _: Bool should fail)
• Type checking for field values (inside declarations)
• Correctly handles surrounding context
• Stable (tested) Some tests in place, will develop as issue Call checking #16 is worked on

[mrRachar]

This got missed for two key reasons:

1. There was an assumption that the Quartz compiler must at least do this
2. Where the expectation was "it works" for the preëxisting codebase, only positive checking was in play. As when the types were right, it worked, this never came up as a problem

[mrRachar]

eWASM-tidy now has these fixes, it will propogate through the eWASM target project