Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flint 5 may be "over-normalizing" message text? #21

Open
jpjpjp opened this issue Mar 24, 2018 · 0 comments
Open

Flint 5 may be "over-normalizing" message text? #21

jpjpjp opened this issue Mar 24, 2018 · 0 comments
Assignees

Comments

@jpjpjp
Copy link
Contributor

jpjpjp commented Mar 24, 2018

The processing of a message in lib/trigger.js includes this call:

          let normalText = text(trigger.message.text).normalize();

This will change text like this: "Bot /echo Repeat this back to me."
To this: "bot echo repeat this back to me "

Essentially removing any forward slashed and converting all the message text to lower case. This will likely break existing bots when migrating to flint 5 if by design.

@nmarus nmarus self-assigned this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants