You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did the update of the new storage/redis module change the overall behavior of storage?
This is sample code from Hotel California:
var htc = bot.recall('htc');
// if htc has not been initialized to bot memory...
if(!htc) {
htc = bot.store('htc', {});
// store default value
htc.enabled = false;
}
I have similar code to this in my bot, but since doing an npm update, I'm now getting a non-null value returned when the key has never been set. Rather it returns an unhandled error object. I also see:
Potentially unhandled rejection [1] Error: bot.recall() could not find the value referenced by id/key
at Object.recall (/Users/jshipher/Dropbox/dev/node/tropo-jira-notification-bot/node_modules/node-flint/storage/memory.js:60:32)
I can handle this in my code, but wondered if this behavior is planned/expected.
The text was updated successfully, but these errors were encountered:
Unexpected, but yes, you are correct. The bot.store/recall/forget code was refactored a few commits back along with the memory storage module to return or reject promises instead of returning a null value. The above would look something like this. I'll update the readme htc example.
bot.recall('htc').then(function(htc){// if htc is found// [ ... ]}).catch(function(err){// if htc is not foundhtc=bot.store('htc',{});// store default valuehtc.enabled=false;});
Of note, the redis storage module still uses the old behavior. I had removed it during a previous commit, it is back now but should be refactored to be interchangeable with the memory storage module.
Did the update of the new storage/redis module change the overall behavior of storage?
This is sample code from Hotel California:
I have similar code to this in my bot, but since doing an npm update, I'm now getting a non-null value returned when the key has never been set. Rather it returns an unhandled error object. I also see:
Potentially unhandled rejection [1] Error: bot.recall() could not find the value referenced by id/key
at Object.recall (/Users/jshipher/Dropbox/dev/node/tropo-jira-notification-bot/node_modules/node-flint/storage/memory.js:60:32)
I can handle this in my code, but wondered if this behavior is planned/expected.
The text was updated successfully, but these errors were encountered: