reported internal ip address / docker

[mo8Zomo0]

Hi!

Piaware reports back the internal IP address and exposes that as a link on the users flightaware page.

https://flightaware.com/adsb/stats/user/ shows the internal IP and port of the local webinterface
under "site information": "Web Interface: View live data (requires local network connection)"
which show something like: http://172.17.0.6:8080/

Especially with using docker this internal address might not even be accessible.

It would be nice if the behaviour could be set / overwritten.

Like behaviour:
default export any internal address)
manual (configure protocol (http/https), host/ip, port as whatever you like)
auto-docker (get the hosts ip/port if this is even possible

[mutability]

Here's the existing logic: https://github.com/flightaware/piaware/blob/master/package/fa_sysinfo.tcl#L292
(tl;dr: parse the output of ip -o route get to 70.42.6.191)
What's the equivalent for detecting a docker environment and extracting the right address?

[resuna]

I just went over this, and there's three things you can do, all of them "not recommended" or "not reliable".

1. Set the docker hostname to the real hostname instead of a container ID, and do a DNS lookup on that. I've done this in a couple places. Not reliable because it assumes you control the docker.
2. Tunnel it into docker using an environment variable. Not reliable for the same reason.
3. Exposing the docker management API inside the container, which basically gives you root on the host. Not recommended.

Oh, I suppose once IPv6 is everywhere it will be a non-issue.

[mo8Zomo0]

As said, an option to define the behaviour and one to define a manual value for the URI could be a fix.

I agree IPv6 would most likely be the most handy thing, though a question would be even if you
use v6 in containers if you would expose it there or concentrated at an other point.

[resuna]

Not doing address translation is kind of a religion for v6 promoters.

Anyway, yeh, just making it some parameter or setting you pass to the program to override the ip address is the way to go. That way it doesn't matter if it's docker or some other NAT/PAT system that's hiding the address from you.