Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for C++ helper code in kernels #948

Open
lockshaw opened this issue Aug 9, 2023 · 1 comment · May be fixed by #992
Open

Add unit tests for C++ helper code in kernels #948

lockshaw opened this issue Aug 9, 2023 · 1 comment · May be fixed by #992
Assignees
Labels
kernels Kernels library

Comments

@lockshaw
Copy link
Collaborator

lockshaw commented Aug 9, 2023

There exist a number of definitions in kernels that aren't part of the kernels themselves, but are used in them. An (inexhaustive and potentially outdated) list of their header files are below:

  • accessor.h
  • allocation.h
  • array_shape.h
  • datatype_dispatch.h
  • legion_dim.h (and its interaction with ff_dim_t)
  • perf_metrics.h
  • per_device_op_state.h
  • profiling.h

The code in these files has not been updated in a while, and may not have been fully implemented. Update this code (for example, dtgen instead of visitable), make sure it's implemented, determine what makes sense to test, and write the corresponding unit tests

@lockshaw
Copy link
Collaborator Author

lockshaw commented Oct 9, 2024

@oOTigger Do you mind taking this over? It's been partially implemented in #992, but as that was created a while ago it may need some updating, polishing, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernels Kernels library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants