Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexflow attempts to register duplicate sharding functors #17

Open
rohany opened this issue Apr 20, 2024 · 2 comments
Open

Flexflow attempts to register duplicate sharding functors #17

rohany opened this issue Apr 20, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rohany
Copy link

rohany commented Apr 20, 2024

Whatever deduplication is occurring here (https://github.com/flexflow/FlexFlow/blob/inference/src/mapper/mapper.cc#L165) is not sufficient to ensure that a unique set of sharding functors IDs is created. At 32 GPUs, i get errors from the runtime that a duplicate sharding functor has been registered. This could be improved with a better hash function ("hacky" solution), or to generate gauranteed fresh IDs from the legion runtime (https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h#L8977), and then store a map of machine view -> sharding id.

@jiazhihao
Copy link
Contributor

@lockshaw @suranap do we have the new hash function integrated in the inference branch? It won't be an issue for 32 GPUs if so I think.

@lockshaw
Copy link
Contributor

@jiazhihao Currently it's only merged into master (flexflow/flexflow-train#1021), though it should be easy to port it to inference

@lockshaw lockshaw added the bug Something isn't working label Jun 3, 2024
@lockshaw lockshaw transferred this issue from flexflow/flexflow-train Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants