We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whatever deduplication is occurring here (https://github.com/flexflow/FlexFlow/blob/inference/src/mapper/mapper.cc#L165) is not sufficient to ensure that a unique set of sharding functors IDs is created. At 32 GPUs, i get errors from the runtime that a duplicate sharding functor has been registered. This could be improved with a better hash function ("hacky" solution), or to generate gauranteed fresh IDs from the legion runtime (https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h#L8977), and then store a map of machine view -> sharding id.
The text was updated successfully, but these errors were encountered:
@lockshaw @suranap do we have the new hash function integrated in the inference branch? It won't be an issue for 32 GPUs if so I think.
Sorry, something went wrong.
@jiazhihao Currently it's only merged into master (flexflow/flexflow-train#1021), though it should be easy to port it to inference
master
inference
jiazhihao
No branches or pull requests
Whatever deduplication is occurring here (https://github.com/flexflow/FlexFlow/blob/inference/src/mapper/mapper.cc#L165) is not sufficient to ensure that a unique set of sharding functors IDs is created. At 32 GPUs, i get errors from the runtime that a duplicate sharding functor has been registered. This could be improved with a better hash function ("hacky" solution), or to generate gauranteed fresh IDs from the legion runtime (https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h#L8977), and then store a map of machine view -> sharding id.
The text was updated successfully, but these errors were encountered: