Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wavelength option to specify sources and monitors #1933

Open
e-g-melo opened this issue Aug 30, 2024 · 0 comments
Open

Add wavelength option to specify sources and monitors #1933

e-g-melo opened this issue Aug 30, 2024 · 0 comments
Assignees

Comments

@e-g-melo
Copy link
Collaborator

Background

In GUI, we allow users to select between wavelength or frequency to define sources and monitors.

Currently, if users select wavelength, they need to provide the minimum and maximum wavelengths and can adjust the bandwidth using the "Customize source bandwidth" parameter.

image

Or they can input the frequency and bandwidth as below.

image

The relation between wavelength and frequency is defined as:

freq0 = (td.C_0 / lamb_min + td.C_0 / lamb_max) / 2
fwidth = customize_source_bandwidth * (td.C_0 / lamb_min - td.C_0 / lamb_max)

For monitors the user can also select between wavelength and frequency, and the conversion is done using freq = td.C_0 / lamb.

image image

Requirement

Some GUI users have requested to set the source using a central wavelength and a wavelength bandwidth, and we have Python users also asking to set sources and monitors using wavelength.

So, we could have the following options to set sources:

  1. freq0 and fwidth
  2. lamb0 and lamb_width
  3. freq_min, freq_max, and customize_source_bandwidth
  4. lamb_min, lamb_max, and customize_source_bandwidth

For monitors, the user could assign a list of frequencies or a list of wavelengths.

In GUI, it would be helpful if we could have a method to return freq0, fwidth, lamb0, lamb_width, freq_min, freq_max, lamb_min, and lamb_max. So, if the user sets, for instance, freq_min and freq_max, we can easily obtain the other values to show in UI when they switch between the available input options.

The customize_source_bandwidth parameter is not that intuitive for users, if we have a better approach to adjust the source bandwidth when the users select min/max that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants