-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add WeChat oauth provider #4050
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds WeChat OAuth provider support to the Flet authentication system. The implementation extends the existing OAuth functionality to accommodate WeChat's specific OAuth flow, which differs from standard implementations. Key changes include modifying the Authorization class, creating a new WeChatOAuthToken class, and implementing a new WeChatOAuthProvider class. Sequence DiagramsequenceDiagram
participant User
participant App
participant WeChatOAuthProvider
participant WeChatAPI
User->>App: Initiate login
App->>WeChatOAuthProvider: Request authorization URL
WeChatOAuthProvider->>WeChatAPI: Generate authorization URL
WeChatAPI-->>User: Present QR code
User->>WeChatAPI: Scan QR code and authorize
WeChatAPI-->>App: Redirect with authorization code
App->>WeChatOAuthProvider: Request token
WeChatOAuthProvider->>WeChatAPI: Exchange code for token
WeChatAPI-->>WeChatOAuthProvider: Return token with openid
WeChatOAuthProvider->>WeChatAPI: Fetch user info
WeChatAPI-->>WeChatOAuthProvider: Return user details
WeChatOAuthProvider-->>App: Return authenticated user
File-Level Changes
Tips and commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pengwon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making the WeChat OAuth URLs (authorization_endpoint, token_endpoint, user_endpoint) configurable parameters in the WeChatOAuthProvider class constructor, rather than hardcoding them.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
sdk/python/packages/flet-runtime/src/flet_runtime/auth/authorization.py
Outdated
Show resolved
Hide resolved
sdk/python/packages/flet-runtime/src/flet_runtime/auth/authorization.py
Outdated
Show resolved
Hide resolved
sdk/python/packages/flet-runtime/src/flet_runtime/auth/providers/wechat_oauth_provider.py
Outdated
Show resolved
Hide resolved
@pengwon Thank you for your contribution! Could you look into resolving conflicts in this PR please? |
* main: (31 commits) Migrate `colors` and `icons` variables to Enums (flet-dev#4180) feat: expose more properties in Controls (flet-dev#4105) feat!: Refactor `Badge` Control to a Dataclass; create new `Control.badge` property (flet-dev#4077) fix: clicking on `CupertinoContextMenuAction` doesn't close context menu (flet-dev#3948) fix dropdown `max_menu_height` (flet-dev#3974) Fix undefined name "Future" --> asyncio.Future (flet-dev#4230) wrap ListTile in material widget (flet-dev#4206) Update CONTRIBUTING.md (flet-dev#4208) TextField: suffix_icon, prefix_icon and icon can be Control or str (flet-dev#4173) feat!: enhance `Map` control (flet-dev#3994) skip running flutter doctor on windows if no_rich_output is True (flet-dev#4108) add --pyinstaller-build-args to pack cli command (flet-dev#4187) fix/feat: make `SearchBar`'s view height adjustable; add new properties (flet-dev#4039) fix: prevent button `style` from being modified in `before_update()` (flet-dev#4181) fix: disabling filled buttons is not visually respected (flet-dev#4090) when `label` is set, use `MainAxisSize.min` for the `Row` (flet-dev#3998) fix: `NavigationBarDestination.disabled` has no visual effect (flet-dev#4073) fix autofill in CupertinoTextField (flet-dev#4103) Linechart: jsonDecode tooltip before displaying (flet-dev#4069) fixed bgcolor, color and elevation (flet-dev#4126) ...
I will have a try. Thank you for your review. |
Description
Added WeChat OAuth Provider by extending the existing OAuthToken class to include WeChat-specific fields
openid
andunionid
, also modify Authorization class to adapt WeChat OAuth flow.Test Code
Type of change
Checklist:
Screenshots (if applicable):
Additional details
Summary by Sourcery
Add support for WeChat as an OAuth provider by implementing a new WeChatOAuthProvider class and extending the OAuthToken class to handle WeChat-specific fields. Update the Authorization class to integrate the WeChat OAuth flow, ensuring proper token and user data management.
New Features:
openid
andunionid
.Enhancements: