Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tracker: Gesture Handling #1529

Closed
8 of 10 tasks
JaffaKetchup opened this issue May 20, 2023 · 2 comments
Closed
8 of 10 tasks

[BUG] Tracker: Gesture Handling #1529

JaffaKetchup opened this issue May 20, 2023 · 2 comments
Assignees
Labels
bug This issue reports broken functionality or another error P: 2 (soon™?) S: core Scoped to the core flutter_map functionality
Milestone

Comments

@JaffaKetchup
Copy link
Member

JaffaKetchup commented May 20, 2023

flutter_map makes extensive use of custom/raw gesture handling, outside of GestureDetector. Much of the code that does this was written in the first few releases, and has not been significantly changed since. However, new gestures have been added in on-top, with little thought to refactor and improve existing gestures (likely because this would/will take such a long time).

This has led to a single file of over 1000 lines of code managing pretty much all the gestures within FM. Obviously, this is not maintainable, and the perfect hiding place for bugs.

To make it worse, gesture handling at this low-level often differs slightly between platforms, which means that manual testing succeeds on one platform, but a bug occurs on another. There is a particular issue with iOS/MacOS in this regard.

To resolve the issues tracked here, a rewrite of the gesture handling system needs to be undertaken. Note that that bugs that occur as a result of gestures, but not directly as a mishandling of gestures (eg. #1682) are not tracked here.

Issues

  1. P: 3 (low) S: core bug
  2. S: core bug external
  3. S: core bug needs triage stale waiting for user response
  4. S: core bug needs triage stale waiting for user response
  5. S: core bug external
    josxha
  6. bug external
    josxha
  7. P: 1 (important) bug
    josxha
  8. P: 3 (low) S: core bug
  9. P: 3 (low) S: core bug
    josxha
  10. P: 3 (low) S: core feature
@JaffaKetchup JaffaKetchup added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing non-fatal and removed needs triage This new bug report needs reproducing and prioritizing labels May 20, 2023
@JaffaKetchup JaffaKetchup changed the title [BUG] MacOS Gesture Issue Tracker [BUG] MacOS/iOS Gesture Issue Tracker Jun 4, 2023
@fleaflet fleaflet locked and limited conversation to collaborators Aug 23, 2023
@JaffaKetchup JaffaKetchup changed the title [BUG] MacOS/iOS Gesture Issue Tracker [BUG] Gesture Issue Tracker Oct 20, 2023
@JaffaKetchup JaffaKetchup changed the title [BUG] Gesture Issue Tracker [BUG] Tracker: Raw Gesture Handling Oct 20, 2023
@JaffaKetchup JaffaKetchup pinned this issue Oct 20, 2023
@josxha josxha changed the title [BUG] Tracker: Raw Gesture Handling [BUG] Tracker: Gesture Handling Nov 21, 2023
@josxha
Copy link
Contributor

josxha commented Nov 21, 2023

Expanded the issue tracker for all kind of bugs with the gesture system.
All issues on this list need to be revalidated after the following is merged:

@josxha josxha self-assigned this Nov 21, 2023
@josxha josxha added this to the v7.0 milestone Dec 2, 2023
@JaffaKetchup JaffaKetchup added the S: core Scoped to the core flutter_map functionality label Dec 10, 2023
@josxha josxha moved this to In progress in Development Jan 21, 2024
@JaffaKetchup JaffaKetchup unpinned this issue Jan 31, 2024
@JaffaKetchup
Copy link
Member Author

Any remaining gesture issues will be tracked individually. Platform specific issues will need to be re-evaluated.

@JaffaKetchup JaffaKetchup closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue reports broken functionality or another error P: 2 (soon™?) S: core Scoped to the core flutter_map functionality
Projects
Archived in project
Development

No branches or pull requests

2 participants