Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Notes field under the recipe #228

Open
meersjo opened this issue Jun 5, 2024 · 6 comments
Open

Additional Notes field under the recipe #228

meersjo opened this issue Jun 5, 2024 · 6 comments
Assignees
Labels
feature New feature or request request Requested by users
Milestone

Comments

@meersjo
Copy link

meersjo commented Jun 5, 2024

I would like to suggest an new freeform "Additional Notes" field under the recipe steps - optionally with markdown support as mentioned in #217 :-)

Some of the usecases I'm thinking of:

  • Alternate ingredient possibilities
  • Notes on how something turns out / may be improved
  • Ideas for or notes on possible variations
  • Clarifications on ingredients, portioning, ...
@flauschtrud flauschtrud added feature New feature or request request Requested by users labels Jun 7, 2024
@uli-on
Copy link

uli-on commented Jun 12, 2024

This enhancement was why I came here 😏👍

@uli-on
Copy link

uli-on commented Jun 12, 2024

Currently I handle annotations with additional paragraphs inside the recipe text itself but by looking at the long string of indicator bullets it makes the recipes look overly complicated and creates confusion about where (how close to the end) in the cooking process I really am.

@flauschtrud
Copy link
Owner

@uli-on For the time being I would suggest to put annotations in the description field (with the additional benefit that it's searchable and you can use hashtags there). But I understand that notes are different from a description and there's value to have both.

@uli-on @meersjo Would you see value in the notes field being searchable (currently only the description, url and ingredients list are)? For example would you like to put tags with hashtags in a notes field? I personally would prefer the description field to do tagging, but I would like to get input from others.

@meersjo
Copy link
Author

meersjo commented Jun 14, 2024

I think there would be some value; particularly when it's being used for ingredient variations; but for me that wouldn't be a major point - my personal usecase is mostly recipes I know well enough that I can find them with a simple title search.

Re: tagging, I think having multiple fields with tagging would needlessly complicate things, even if a particular tag might occasionally apply specifically to a variation. I'm very much in favour of the KISS principle :-)

@uli-on
Copy link

uli-on commented Jun 16, 2024

I've never tried putting something else into the description field other than a short/two liner description. But i see you've provided it with capacities for overflowing. I'd prefer a more natural order, though, ingredients first followed by recipe, variations & annotations thereafter.

If adding search capabilities is much effort I'd gladly accept a very basic version without search.

Currently I'd have no need for categories and tags, but that might come in handy one day ...

@flauschtrud
Copy link
Owner

If adding search capabilities is much effort I'd gladly accept a very basic version without search.

It's not necessarily a question of implementation effort but moreso of search performance. It wouldn't make sense to add data to the search index if people don't actually want to search in it (could even be confusing maybe), so this is why I ask.

@flauschtrud flauschtrud added this to the v1.3 milestone Dec 9, 2024
flauschtrud added a commit that referenced this issue Dec 12, 2024
Fixed build warning concerning room.schemaLocation.
flauschtrud added a commit that referenced this issue Dec 12, 2024
Removed @FlakyTest annotation for certain tests.
flauschtrud added a commit that referenced this issue Dec 12, 2024
flauschtrud added a commit that referenced this issue Dec 12, 2024
Adding more devices for testing locally.
flauschtrud added a commit that referenced this issue Dec 12, 2024
Marked SeasonalCalendarHolderTest as flaky.
flauschtrud added a commit that referenced this issue Dec 12, 2024
flauschtrud added a commit that referenced this issue Dec 12, 2024
Changed build.yml to only run tests on pixel2api30 device.
@flauschtrud flauschtrud self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request request Requested by users
Projects
None yet
Development

No branches or pull requests

3 participants