Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Creating Notifications section outdated #385

Open
Chealer opened this issue Aug 26, 2021 · 0 comments
Open

README: Creating Notifications section outdated #385

Chealer opened this issue Aug 26, 2021 · 0 comments

Comments

@Chealer
Copy link

Chealer commented Aug 26, 2021

The README's Creating Notifications section contains a table with method signatures like the following:
success(title: any, content?: any, override?: any, context?: any)

At least the first 7 entries are outdated, as the title argument is now optional.
Additionally, a set(notification: Notification, to: boolean): Notification method is not documented.

By the way:

  1. "This are the currently available access methods:" should read "These are the currently available access methods:".
  2. Most descriptions refer to "the provided title and content", when providing both is in fact optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant