-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter and linter for the frontend #107
Comments
Sounds good. Shall we try to get to a place where we have no outstanding PRs and then sweep through the code and (a) change Analysis to Project (b) enforce prettier formatting? |
Cool. Once those two are merged (from my perspective they are ready to go), could you make a utility script that formats all .ts/.tsx files, and then we can review whether that is suitable? Do we want to have a pre commit hook? CI check? VSCode setting? Then I'll fix any conflicts in the other 2 PRs. |
We already have pre-commit on the backend — that seems like a good choice locally, but setting up your VSCode can also help obviously. I will update our config and run the full format after they’re merged |
Sounds good... I snuck one more in there #108 which I think could be merged right away. |
I think at least a few of the recent merge conflicts we've had on PRs have been due to formatting differences between editors rather than actual content changing. It would be nice to have a consistent style we can all just tell our editor to use and then forget about it.
I don't have a super strong opinion on which, but to make this concrete I would suggest Prettier with a minimal config. For Stan-Web-Demo I used
The text was updated successfully, but these errors were encountered: