Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Allow real values? #86

Open
eickenberg opened this issue Oct 13, 2023 · 1 comment
Open

ENH Allow real values? #86

eickenberg opened this issue Oct 13, 2023 · 1 comment

Comments

@eickenberg
Copy link
Collaborator

We could consider allowing real tensors for the finufft values that then are cast, possibly with the issue of a warning.

Similarly, it may be useful to allow to just specify values=1, or any float, which would then be broadcast to the correct dimension. This would be particularly useful if one is just interested in point locations. Could even consider making 1 the default argument, but that might lead to some unexpected behavior

@WardBrian
Copy link
Collaborator

Since this requires allocating something 2*sizeof(values) I think it's probably something we want to make the user explicitly do.

Hopefully finufft upstream gets a real specialization one day, and then we could accept reals and use that.

@WardBrian WardBrian changed the title Allow real values? ENH Allow real values? Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants