Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is cufiNUFFT using streams for at the moment #117

Closed
JBlaschke opened this issue Nov 19, 2021 · 2 comments
Closed

What is cufiNUFFT using streams for at the moment #117

JBlaschke opened this issue Nov 19, 2021 · 2 comments

Comments

@JBlaschke
Copy link
Contributor

While researching flatironinstitute/jax-finufft#4 (comment) I came across:

cudaStream_t* streams =(cudaStream_t*) malloc(d_plan->opts.gpu_nstreams*
,
and was wondering what cufiNUFFT is using streams for. I searched from streams and couldn't find any places where this is used, so is this WIP?

@MelodyShih
Copy link
Collaborator

MelodyShih commented Nov 19, 2021

Hi Johannes, no, this is not WIP and the lines of codes can be removed. The streams were created in an experiment of accelerating computations when we have multiple data with same locations of NUpts.

@JBlaschke
Copy link
Contributor Author

Right! Thanks for the info. I will pick up #99 again, and move the stream descriptor into a struct that also sores device and context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants