Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install -e is broken #1356

Closed
pgunn opened this issue May 31, 2024 · 4 comments
Closed

pip install -e is broken #1356

pgunn opened this issue May 31, 2024 · 4 comments

Comments

@pgunn
Copy link
Member

pgunn commented May 31, 2024

The -e install doesn't put paths in the right place for caimanmanager to find them, looking in paths like:
/home/pgunn/miniconda3/envs/caibuild/share/caiman

We need to handle this case better.

@pgunn
Copy link
Member Author

pgunn commented May 31, 2024

It's unclear whether this is because the install plumbing is bad or caimanmanager needs to be smarter. Probably the former though. This may have happened when we modernised the pip plumbing a few releases back, as I know this used to work.

@pgunn
Copy link
Member Author

pgunn commented May 31, 2024

Actually, caimanmanager install --inplace does the right thing with an editable install, but only if you do it from within the sourcedir.

I may be able to find a more elegant way to do this (maybe caimanmanager should detect if the install is editable and then go find the sourcedir) and then I wouldn't need the flag, but if not, I at least need to document editable installs better in the readme.

@pgunn
Copy link
Member Author

pgunn commented May 31, 2024

Looks like the data_files limitation is a known bug in setuptools:
pypa/setuptools#3399

Currently looking into whether there's any way to force setup.py to populate share/ with our data_files anyway or if there's any way to disable editable mode; either approach seems workable.

@pgunn
Copy link
Member Author

pgunn commented May 31, 2024

Should be fixed by #1357

@pgunn pgunn closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant