Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using flathub provided OpenJDK SDK #86

Open
CC-Hsu opened this issue Dec 22, 2024 · 4 comments
Open

Using flathub provided OpenJDK SDK #86

CC-Hsu opened this issue Dec 22, 2024 · 4 comments

Comments

@CC-Hsu
Copy link

CC-Hsu commented Dec 22, 2024

Hi,

There are many Flathub packages that are rely on OpenJDK SDK, such as Shattered Pixel Dungeon or Unciv.

And there are many supported OpenJDK versions provided in Flathub

It would be great if PrismLauncher can also include this support, too.

Best Regards.

@Scrumplex
Copy link
Collaborator

We used to ship these but decided to drop them in favor of Prism Launcher's built-in Java downloader.

@CC-Hsu
Copy link
Author

CC-Hsu commented Dec 23, 2024

Hi, Scrumplex,

Thanks for your reply, I can understand that these java-based games bind a specific OpenJDK version in this way,
while PrismLauncher aims to provide flexibility on choosing different version Java for different version MC.

I remind that Flatpak VS Code can supports multiple SDK Flatpak packages without any pre-specified SDK package name and version; but I can only find the below line and not sure whether this is the exact line for this magic.
https://github.com/flathub/com.visualstudio.code/blob/master/com.visualstudio.code.yaml#L4

I guess maybe this might be a way, too.

@Scrumplex
Copy link
Collaborator

Previously we had to copy the contents from the OpenJDK SDKs to our Flatpak, which made our application significantly larger to download. Note that we currently would need to ship three JREs

@CC-Hsu
Copy link
Author

CC-Hsu commented Dec 24, 2024

Yeah, I can understand shipping built-in Java runtime is a nightmare.

But I find that VS Code Flatpak is shipped without pre-packaged language SDKs:
it can be installed alone without JDK, golang, rust, .Net ...etc included,
and it recognize a runtime/compiler under /lib/sdk/ directory as someone install any org.freedesktop.sdk.* package.

Would that be a possible way to make Flatpak OpenJDK SDKs as possible runtimes for the PrismLauncher flatpak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants