Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Deneb payload #176

Closed
halo3mic opened this issue Jan 25, 2024 · 3 comments · Fixed by #188 or #192
Closed

No Deneb payload #176

halo3mic opened this issue Jan 25, 2024 · 3 comments · Fixed by #188 or #192
Assignees
Labels
bug Something isn't working

Comments

@halo3mic
Copy link
Contributor

When submitting the block to the relay via Suave I get bad request with error {"code":400,"message":"not deneb payload"}\n.

The source of the error is here in the relay code.

It appears suave-geth and suave-execution-geth need support for the new payload with blobs.

@lthibault lthibault self-assigned this Feb 5, 2024
@lthibault
Copy link
Contributor

lthibault commented Feb 7, 2024

@halo3mic Okay, I think I've narrowed it down a bit.

I believe the issue is in buildEthBlock, here. Notice that it's building a Capella block submission request. Presumably that should be a Deneb variant. I believe the attestantio/go-builder/client library may need a version bump.

@lthibault lthibault added the bug Something isn't working label Feb 7, 2024
@lthibault lthibault reopened this Feb 7, 2024
@lthibault
Copy link
Contributor

Per conversation on Telegram, #188 has not resolved the issue.

@lthibault
Copy link
Contributor

lthibault commented Feb 9, 2024

Okay, I think the beacon root needs to be set here, as beaconRoot is part of the Header struct when calculating the block hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants