feat: new job type for sync canary jobs #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
job-context
branch
4 times, most recently
from
37434cc to
0df21fe
Compare
|
|
yashmehrotra
force-pushed
the
job-context
branch
from
bbab9a3 to
0e945ef
Compare
yashmehrotra
force-pushed
the
job-context
branch
from
0e945ef to
e7d59ff
Compare
moshloop
reviewed
Oct 25, 2023
| if runner.IsCanaryIgnored(&job.Canary.ObjectMeta) { | ||
| return | ||
| func (j CanaryJob) Run(ctx dutyjob.JobRuntime) error { | ||
| ctx.GetSpan().SetAttributes(attribute.String("canary-id", j.DBCanary.ID.String())) |
There was a problem hiding this comment.
I don't think we should be recording traces for canary runs - they are traced internally using check_status, not sure what pushing them to opentelemetry would add ? A slow canary is more likely due to a slow remote server than a slow canary checker db ?
There was a problem hiding this comment.
Did it for general observability, like record all transactions to have complete overview and have a general idea of how much time the checks run is taking compared to the other database calls in the job
adityathebe
reviewed
Oct 30, 2023
pkg/db/canary.go
Outdated
| @@ -278,7 +279,7 @@ func FindCheck(canary pkg.Canary, name string) (*pkg.Check, error) { | |||
| return &model, nil | |||
| } | |||
|
|
|||
| func FindDeletedChecksSince(ctx context.Context, since time.Time) ([]string, error) { | |||
| func FindDeletedChecksSince(ctx gocontext.Context, since time.Time) ([]string, error) { | |||
There was a problem hiding this comment.
Maybe use duty's context for this as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.