code review feedback

flame-engine · Dec 2, 2024 · bcd5729 · bcd5729
1 parent 98612d7
commit bcd5729
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/flame/lib/src/rendering/shadow3d_decorator.dart b/packages/flame/lib/src/rendering/shadow3d_decorator.dart
@@ -131,7 +131,7 @@ class Shadow3DDecorator extends Decorator {
   Paint? _paint;
   Paint _makePaint() {
     final paint = Paint();
-    final color = baseColor.withAlpha((opacity * 255).toInt());
+    final color = baseColor.withValues(alpha: opacity);
     paint.colorFilter = ColorFilter.mode(color, BlendMode.srcIn);
     if (_blur > 0) {
       paint.imageFilter = ImageFilter.blur(sigmaX: blur, sigmaY: blur / _scale);

diff --git a/packages/flame/test/_goldens/shadow3d_decorator_3.png b/packages/flame/test/_goldens/shadow3d_decorator_3.png
diff --git a/packages/flame/test/rendering/shadow3d_decorator_test.dart b/packages/flame/test/rendering/shadow3d_decorator_test.dart
@@ -81,7 +81,8 @@ void main() {
               ..xShift = 250.0
               ..yScale = 1.5
               ..opacity = 0.4
-              ..blur = 1.0,
+              ..blur = 1.0
+              ..baseColor = BasicPalette.red.color,
           ),
         ]);
       },