Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between features objects and features strings in cross-tree constraints #62

Open
jmhorcas opened this issue May 3, 2022 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@jmhorcas
Copy link
Contributor

jmhorcas commented May 3, 2022

When storing cross-tree constraints in the feature model, the AST supports any type of nodes.
Currently, when reading the cross-tree constraints in the readers of the feature model the AST is built using the features' names which is OK, but then methods in the Feature Model class should return Features as objects, and actually there are some methods that returns the features' names such as the get_features() method inside the Constraint` class.

@jmhorcas jmhorcas added the bug Something isn't working label May 3, 2022
@jmhorcas jmhorcas added this to the Sprint 3 (After MODEVAR) milestone May 3, 2022
@jmhorcas jmhorcas self-assigned this May 3, 2022
@jagalindo
Copy link
Member

That's a change that might impact a bunch of places. This should be analyzed with calm

@jagalindo jagalindo added invalid This doesn't seem right and removed bug Something isn't working labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants