Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None of the demos work in Firefox or Safari when running locally using the dev server #267

Open
haach opened this issue May 16, 2024 · 4 comments · May be fixed by #280
Open

None of the demos work in Firefox or Safari when running locally using the dev server #267

haach opened this issue May 16, 2024 · 4 comments · May be fixed by #280
Labels
documentation Improvements or additions to documentation

Comments

@haach
Copy link

haach commented May 16, 2024

Hey! I wanted to use this polyfill in my library, but when I fired up the demos locally, I noticed that none of them work properly in either OSx Firefox or Safari. On Chrome everything appears to work as expected as far as I can tell.

I am on macOS Ventura (13.6.6)

Here are some recordings:

Chrome, Version 124.0.6367.158
https://github.com/flackr/scroll-timeline/assets/34210193/f2688d5e-8d80-428b-b532-6fb1966765ba

Firefox, version 106.0.1
https://github.com/flackr/scroll-timeline/assets/34210193/06cfab04-253a-4974-b65c-9dd86d51c413

Safari, Version 17.4.1
https://github.com/flackr/scroll-timeline/assets/34210193/feba95f6-ddd6-4415-88c9-d9f870d60fda

Has anyone else ran into a similar issue? I am interested in the scroll( ) function polyfill
@Floran-mtte
Copy link

Hey @haach, same here. It isn't working locally or when using the CDN on Safari iOS and macOS 17.4."

@bramus
Copy link
Collaborator

bramus commented May 18, 2024

Check the console. You’ll see an error that it can’t load thescroll-timeline.js file.

E.g, in Safari:

Failed to load resource: the server responded with a status of 404 (Not Found)

The fix is that you need to build the project first before serving the demos.

# Build
npm run build

# Start DevServer
npm run dev

Preferably, npm run dev would also build the project first (and set up a watcher).

@bramus bramus changed the title None of the demos seem to work on OSx Firefox or Safari None of the demos work in Firefox or Safari when running locally using the dev server May 18, 2024
@haach
Copy link
Author

haach commented May 21, 2024 •
edited
Loading

Check the console. You’ll see an error that it can’t load thescroll-timeline.js file.

E.g, in Safari:

Failed to load resource: the server responded with a status of 404 (Not Found)

The fix is that you need to build the project first before serving the demos.

# Build
npm run build

# Start DevServer
npm run dev

Preferably, npm run dev would also build the project first (and set up a watcher).

That worked :) Thank you!!

@haach haach closed this as completed May 21, 2024
@bramus
Copy link
Collaborator

bramus commented May 21, 2024

Reopening as it’s best that we get this fixed, or at least make a note of it in the README.

@bramus bramus reopened this May 21, 2024
manuelmeister added a commit to manuelmeister/scroll-timeline that referenced this issue Aug 12, 2024
@manuelmeister
Improve demo start
2f93789 
Fix flackr#267
@manuelmeister manuelmeister linked a pull request Aug 12, 2024 that will close this issue
Open
@bramus bramus added the documentation Improvements or additions to documentation label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve demo start manuelmeister/scroll-timeline
3 participants
@bramus @haach @Floran-mtte