intercom backend refactoring: make data flow comprehensible #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jstucke
force-pushed
the
intercom-refactoring
branch
from
01c8b24
to
be061ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 91.94% 91.93% -0.02%
==========================================
Files 377 376 -1
Lines 22295 21029 -1266
==========================================
- Hits 20499 19332 -1167
+ Misses 1796 1697 -99 ☔ View full report in Codecov by Sentry. |
dorpvom
reviewed
Nov 29, 2024
| InterComBackEndBinarySearchTask(), | ||
| InterComBackEndUpdateTask(self.analysis_service.update_analysis_of_object_and_children), | ||
| InterComBackEndDeleteFile( | ||
| self.analysis_service.update_analysis_of_object_and_children, |
There was a problem hiding this comment.
Why do I need to update_analysis_of_object_and_children if I want to delete a firmware?
| self.process.start() | ||
|
|
||
| def shutdown(self): | ||
| self.stop_condition.value = 1 |
There was a problem hiding this comment.
I guess this plays into the make data flow comprehensible goal, but this does create another dozen or so file descriptors compared to sharing one stop condition over all listeners, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.