Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cve_lookup: added support for CVSS metrics v4.0+ #1233

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jul 2, 2024

  • fixed a KeyError in the CVE data parsing
  • added generic support for more versions of CVSS metrics than v2, v3.0 and v3.1 (as long as the general structure of the data does not change)
    • changed the schema of the internal DB so that all scores are stored as JSON instead of storing v2 and v3.x separately
      • these changes require rebuilding the database by rerunning the installation for existing FACT installations!
    • adjusted jinja filters and the template

@jstucke jstucke requested a review from maringuu July 2, 2024 09:48
@jstucke jstucke self-assigned this Jul 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (42f7320) to head (041ecc7).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...lysis/cve_lookup/internal/database/db_interface.py 50.00% 4 Missing ⚠️
...ugins/analysis/cve_lookup/internal/data_parsing.py 92.85% 1 Missing ⚠️
src/web_interface/filter.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   91.96%   91.84%   -0.12%     
==========================================
  Files         377      376       -1     
  Lines       22360    20964    -1396     
==========================================
- Hits        20564    19255    -1309     
+ Misses       1796     1709      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants