Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing prop to change tag to listen for scroll #51

Open
Freysi21 opened this issue Jul 21, 2019 · 1 comment
Open

Allow passing prop to change tag to listen for scroll #51

Freysi21 opened this issue Jul 21, 2019 · 1 comment

Comments

@Freysi21
Copy link

Hi

Love the component been using it a bunch. I just refactored my website to handle parallax scrolling with translateZ and perspective. This scrambled a bunch of stuff for example a fixed header within the body layout. So I needed to move the overflow scroll property from body to a child tag.

Now the visibility component doesn't work since it only listens to window scroll or document scroll.

@Freysi21
Copy link
Author

I started this pull request

https://github.com/fkhadra/react-on-screen/pulls

I change the .gitignore to refrence the repo in my package.json.

Essentially I just passed in the id of the new scrolling element to listen to and search it with getElementById

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant