Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion regarding to moderation #100

Closed
MrTide opened this issue May 3, 2023 · 5 comments
Closed

Suggestion regarding to moderation #100

MrTide opened this issue May 3, 2023 · 5 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@MrTide
Copy link

MrTide commented May 3, 2023

Hello once again, i am not sure this is the right place to ask but
I can't believe how awesome wowchat is i am falling in love with it
I wonder if you can add ingame moderation function to it as well, read a word and apply a command like gm commands or discord/gkick command and so on.
Thank you in for taking the time and creating this master piece!
It would be really nice if you consider.
I have it on weakaura atm but it would be really nice

@fjaros
Copy link
Owner

fjaros commented May 4, 2023

Duplicate of #29 . The reasons listed in that issue are still relevant.

@MrTide
Copy link
Author

MrTide commented May 4, 2023

Duplicate of #29 . The reasons listed in that issue are still relevant.

Thank you for taking a look, my suggestion was that maybe this bot could read a channel or say/yell chat ingame and apply a command to that player more like trigger (player X said the N-Word .kick playername or /kick from the channel) so basically it just writes something, i dont want it to send anything to the server, thanks for taking a look <3

@fjaros
Copy link
Owner

fjaros commented May 4, 2023

Ah I see, you're talking about Discord moderation from in-game. Either way, the access control would still have to be designed and implemented. You wouldn't want everyone who can talk to the bot having access to kick people from Discord. It's not a bad idea, but as this project is on maintenance mode, I don't plan on implementing such a large feature. And also, the workaround of just going to your Discord client and kicking that person out is quite sufficient.

@MrTide
Copy link
Author

MrTide commented May 4, 2023

Ah I see, you're talking about Discord moderation from in-game. Either way, the access control would still have to be designed and implemented. You wouldn't want everyone who can talk to the bot having access to kick people from Discord. It's not a bad idea, but as this project is on maintenance mode, I don't plan on implementing such a large feature. And also, the workaround of just going to your Discord client and kicking that person out is quite sufficient.

not exactly i want it to read > catch and act on it by itself, we just enter banned words and the commands to use like .kick or /ckick or what ever. totally unrelated to discord
permissions can be given ingame so that is not the issue
Something like this but ofc in the config file
image
image
Uploading image.png…

eitherway i love wowchat and it made my life so much easier thank you <3

@fjaros
Copy link
Owner

fjaros commented May 4, 2023

I see so in the end you do want wow in-game chat moderation... Sorry it is very unclear from your messages what you actually mean in the context of the functionality of the bot.
This unfortunately will require some coding modifications. In the simplest form:

  1. You will have to setup a relay from that channel -> discord
  2. You can get inspired by implementation of filters - https://github.com/fjaros/wowchat/blob/master/src/main/scala/wowchat/discord/Discord.scala#L73
  3. You will have to implement a function like shouldFilter, let's call it "shouldModerate". Inside this function, you should decide what action to take based on the content of the message, channel it is sent in, and who sent it.
  4. If you decide an action is needed, you can then use the Global.game.foreach(_.sendMessageToWow()) construct to send the moderation command back to the game server. You can see this function being used to notify users of errors (such as for a failed @ tag notification).

Happy coding 😄

@fjaros fjaros added duplicate This issue or pull request already exists enhancement New feature or request labels May 6, 2023
@fjaros fjaros closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants