Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] date is not recognized in balance sheet report #53

Closed
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Jan 9, 2025 · 0 comments · Fixed by #54
Closed
1 of 4 tasks

[Bug] date is not recognized in balance sheet report #53

fivetran-joemarkiewicz opened this issue Jan 9, 2025 · 0 comments · Fixed by #54
Assignees
Labels
error:unforced type:bug Something is broken or incorrect

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Jan 9, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

It seems that this logic is not working as expected. We've seen in some Snowflake warehouses that the below error message is being served and causing a data model failure. As such, there must be something that needs to be adjusted within the logic to ensure we can account for leap years.

Relevant error log or model output

Date '2025-2-29' is not recognized

Expected behavior

The data model can handle leap years

Possible solution

Update this logic to account for the leap year. We may need to play around with the date format in Snowflake and make sure we can update the logic to work as expected.

Edit: I have since creating this issue that the error is also occurring potentially on BigQuery warehouses. We should probably bring this entire logic into scope for all warehouses when addressing the issue.

dbt Project configurations

Default

Package versions

Latest

What database are you using dbt with?

snowflake and bigquery

How are you running this dbt package?

Fivetran Quickstart Data Model

dbt Version

Latest

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance.
  • No.
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:bug Something is broken or incorrect label Jan 9, 2025
@fivetran-catfritz fivetran-catfritz self-assigned this Jan 10, 2025
@fivetran-catfritz fivetran-catfritz linked a pull request Jan 10, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:unforced type:bug Something is broken or incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants