Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The filtermask submodule isn't valid Python! #11

Open
RobPearce opened this issue Jul 17, 2020 · 0 comments
Open

The filtermask submodule isn't valid Python! #11

RobPearce opened this issue Jul 17, 2020 · 0 comments

Comments

@RobPearce
Copy link

RobPearce commented Jul 17, 2020

The author of the filtermask module appears to have been writing in a language other than Python.
The class defines two __init__ methods in an attempt to create overloaded constructors like in C++ or Java. This does not work in Python - the second definition merely overwrites the first and the first is thrown away.
Once in the __init__ method, the first thing that happens is the 'registers' member is set to be an empty list of zero length. Then it tries to set the first four elements of this zero-length list, which don't exist because it's zero length!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant