Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unnecessary refactorisations when matrices haven't changed #569

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Prevent unnecessary refactorisations when matrices haven't changed #569

wants to merge 15 commits into from

Conversation

JHopeCollins
Copy link
Member

Addresses #565

Will commit solver types one-by-one to see how CI times change. Flamegraphs at each stage to follow.

@JHopeCollins JHopeCollins self-assigned this Nov 4, 2024
@JHopeCollins
set constant_jacobian for mass matrices in SIQN forcing solvers
9b2a545
@JHopeCollins
direct solver breaks RK test
4257fcf
@JHopeCollins
tighter solver tolerance breaks RK test
45077a4
@JHopeCollins
Merge remote-tracking branch 'origin/main' into JHopeCollins/lvs_cons…
3df9ca9 
…tant_jacobian
@JHopeCollins
fixing the jacobian of linear time derivatives for explicit RK break…
6055d24 
…s boussinesq test
@JHopeCollins
fixing the preconditioner of linear time derivatives for explicit RK…
e41439c 
… does not break test
@JHopeCollins
fieldsplitting ERK mass solves breaks LSWE test
fed1bdc
@JHopeCollins
fix the matrices in the linear solvers between reference state updates
50dd3ba
@JHopeCollins
remove fieldsplitting of ERK mass solves for now
43c8831
@JHopeCollins
Using an iterative method for the mass solves in the SIQN forcing ter…
2849a2e 
…ms breaks boussinesq test
@JHopeCollins
fix the matrices in the diagnostics
43c4de8
@JHopeCollins
fieldsplitting ERK mass solves for nonlinear time-derivatives
e2cc19e
@JHopeCollins
all mass solver updates that break tests
c5fd4d8
@JHopeCollins
fieldsplit SIQN forcing mass solves
2e5158f
@JHopeCollins JHopeCollins mentioned this pull request Nov 7, 2024
Merged
@JHopeCollins JHopeCollins linked an issue Nov 7, 2024 that may be closed by this pull request
Only refactor matrices when necessary #565
Open
@tommbendall tommbendall added the optimisation Involves optimising performance of code label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JHopeCollins JHopeCollins

Labels
optimisation Involves optimising performance of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only refactor matrices when necessary
2 participants
@JHopeCollins @tommbendall