Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RK implementations of Forward and Backward Euler with simpler versions #515

Open
tommbendall opened this issue Jul 22, 2024 · 0 comments
Open

Replace RK implementations of Forward and Backward Euler with simpler versions #515

tommbendall opened this issue Jul 22, 2024 · 0 comments
Labels
good for hackathon Issues that are good to tackle in a hackathon tidying Pull requests or issues that involve tidying up code

Comments

@tommbendall
Copy link
Contributor

tommbendall commented Jul 22, 2024 •
edited
Loading

ForwardEuler is currently implemented through the more general multi-stage Runge Kutta schemes. It might be clearer to implement it straight from the TimeDiscretisation base class.

We might still want a non-namespaced implementation of ForwardEuler for testing of generalised schemes.
@tommbendall tommbendall added tidying Pull requests or issues that involve tidying up code good for hackathon Issues that are good to tackle in a hackathon labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for hackathon Issues that are good to tackle in a hackathon tidying Pull requests or issues that involve tidying up code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tommbendall