Configuring transport options #263
Closed
tommbendall
started this conversation in
Design discussion
Replies: 1 comment
-
This has been resolved by #382 ! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
How should transport options be configured in gusto?
Currently the default is for every variable to use DG upwind, and the forms for these are generated for the residual in the equations class. A specific time discretisation is then passed to the timestepper.
One suggestion is that the transport forms could be added as labels to the full equation. The equation could take
transport_options
as an argument, determining what forms to use for transport. However it seems the time discretisation still need to see thesetransport_options
, which are used for the wrappers for embedded DG and recovered methods. This may not be very neat...How do we best specify the forms used for the transport? i.e. upwind or average, what the integration by parts is, whether to add a vector manifold correction or not, etc.
Two other related issues are:
Beta Was this translation helpful? Give feedback.
All reactions