Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getStatus function #61

Open
coelner opened this issue Dec 21, 2017 · 5 comments · May be fixed by #124
Open

getStatus function #61

coelner opened this issue Dec 21, 2017 · 5 comments · May be fixed by #124

Comments

@coelner
Copy link
Contributor

coelner commented Dec 21, 2017

we should add a getStatus function where we select which bit is returned from the register.

@finitespace
Copy link
Owner

finitespace commented Dec 21, 2017

I don't understand what this means. You want a function to return the digs?

@coelner
Copy link
Contributor Author

coelner commented Dec 22, 2017

there is a status register at 0xF3 where bit 3 switch to '1' when a measurement is active. bit 0 shows only the copy of NVM data. (I'm not sure what conversion in this context means)
bit 3 is more important to know about, because we could check if a measurement is running and wait until the bit flips to '0' and read then the measured values.

@finitespace finitespace added this to the Version_3.0.0 milestone Dec 23, 2017
@finitespace
Copy link
Owner

This seems like it should be a private function that we check before returning a measurement. I wonder if we are returning the data before the filter buffer can be populated in #59.

@finitespace
Copy link
Owner

finitespace commented Dec 27, 2017

I have added this function in the status branch. I need to do some testing on it to make sure it makes a measurement correctly while checking the status bits (see ReadData() for changes to flow). This might also cause the changes to #59/#62 to be unnecessary.

@finitespace
Copy link
Owner

We need to update the branch and create a PR.

@finitespace finitespace linked a pull request Feb 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants