TClasses throws Exception

[LokiMidgard]

The Constructor throws a lot of Exceptions.

I think the Problem is that the if always returns true. If Common.ReadWord(Reader) returns 0, this Value will be decremented by one. That leads to the maximum value of Uint. That is greater than 0.

      public TClasses(BinaryReader Reader, TConstantPool ConstantPool)
        {
            InnerClassInfoIndex = 0;
            InnerClassInfo = null;
            OuterClassInfoIndex = 0;
            ;
            OuterClassInfo = null;
            InnerNameIndex = 0;
            ;
            InnerName = null;
            InnerClassAccessFlags = 0;
            ;

            try
            {
                InnerClassInfoIndex = Common.ReadWord(Reader);
                InnerClassInfoIndex--;
                OuterClassInfoIndex = Common.ReadWord(Reader);
                OuterClassInfoIndex--;
                InnerNameIndex = Common.ReadWord(Reader);
                InnerNameIndex--;
                InnerClassAccessFlags = Common.ReadWord(Reader);

                // resolve references
                if (InnerNameIndex >= 0) // Always true because ushort has no value below 0
                {
                    InnerName = (ConstantUtf8Info)ConstantPool.Item(InnerNameIndex);
                    InnerName.References++; // Check for Null to avoid Exceptions
                }
                if (InnerNameIndex >= 0) // Always true because ushort has no value below 0
                {
                    InnerClassInfo = (ConstantClassInfo)ConstantPool.Item(InnerClassInfoIndex);
                    InnerClassInfo.References++;// Check for Null to avoid Exceptions
                }
                if (InnerNameIndex >= 0) // Always true because ushort has no value below 0
                {
                    OuterClassInfo = (ConstantClassInfo)ConstantPool.Item(OuterClassInfoIndex);
                    OuterClassInfo.References++;// Check for Null to avoid Exceptions
                }
            }
            catch (Exception e)
            {
                // do nothing
            }
        }

[fileoffset]

Thanks for reporting this bug, you are most correct.

Do you have any .class files which I can use to test the fix for this?

[LokiMidgard]

I'm sorry, I can't find the project in my backups.
I can only say that it happened unsing the Jar of this Project: http://helden-software.de/ (homepage) http://download.helden-software.de/download3.php (download)

[fileoffset]

Cool thanks, I'm looking to change the code structure to fix this - it seems to be endemic. I'm going to try and add some automated tests as well.